code/core/src/telemetry/package-json.ts (1)

32-35: Optional: normalize the parent argument to a URL.

Passing process.cwd() works in practice, but Node’s import.meta.resolve expects a URL-like parent. Using pathToFileURL(process.cwd()).href is more robust across runtimes.

-    let resolvedPackageJsonPath = pkg.up({
-      cwd: fileURLToPath(import.meta.resolve(packageName, process.cwd())),
-    });
+    let resolvedPackageJsonPath = pkg.up({
+      cwd: fileURLToPath(import.meta.resolve(packageName, pathToFileURL(process.cwd()).href)),
+    });

docs/_snippets/storybook-main-pnpm-with-module-resolution.md (1)

26-31: Remove unused import in TS snippet.

join is no longer used after switching to template literals.

-import { dirname, join } from 'node:path';
+import { dirname } from 'node:path';

code/lib/cli-storybook/src/automigrate/fixes/wrap-getAbsolutePath-utils.ts (1)

165-171: Provide cooked values in TemplateElement nodes.

@babel/types prefers both raw and cooked. Supplying only raw can trip tooling/print edge cases.

-                  t.templateLiteral(
-                    [
-                      t.templateElement({ raw: '' }),
-                      t.templateElement({ raw: '/package.json' }, true),
-                    ],
-                    [t.identifier('value')]
-                  ),
+                  t.templateLiteral(
+                    [
+                      t.templateElement({ raw: '', cooked: '' }),
+                      t.templateElement({ raw: '/package.json', cooked: '/package.json' }, true),
+                    ],
+                    [t.identifier('value')]
+                  ),

MIGRATION.md (1)

570-581: Clarify builder path vs file URL in example.

import.meta.resolve() typically returns a file URL; the text/comment shows a filesystem path. To avoid confusion (and to satisfy “fully resolved path”), either convert to a path or update the comment.

Option A (path string):

-import { dirname } from 'node:path';
+import { dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
 …
-  builder: import.meta.resolve('@storybook/builder-vite'),
-  // 👆 results in eg. `/absolute/path/node_modules/@storybook/builder-vite/index.js
+  builder: fileURLToPath(import.meta.resolve('@storybook/builder-vite')),
+  // 👆 results in e.g. `/absolute/path/node_modules/@storybook/builder-vite/index.js`

Option B (keep URL): adjust the comment to “file URL”.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

code/lib/create-storybook/src/generators/baseGenerator.ts (2)

399-419: Generated ESM imports: prefer node: specifiers and correct TS return type

• Use node:-prefixed builtins in generated code to match Node ESM guidance and your docs.
• The TS variant should return string, not any.

Apply this diff to the generated prefixes:

-          'import { dirname } from "path"',
-          'import { fileURLToPath } from "url"',
+          'import { dirname } from "node:path";',
+          'import { fileURLToPath } from "node:url";',
@@
-            function getAbsolutePath(value) {
-              return dirname(fileURLToPath(import.meta.resolve(`${value}/package.json`)))
+            function getAbsolutePath(value) {
+              return dirname(fileURLToPath(import.meta.resolve(`${value}/package.json`)));
             }`
             : dedent`/**
           * This function is used to resolve the absolute path of a package.
           * It is needed in projects that use Yarn PnP or are set up within a monorepo.
           */
-          function getAbsolutePath(value: string): any {
-            return dirname(fileURLToPath(import.meta.resolve(`${value}/package.json`)))
+          function getAbsolutePath(value: string): string {
+            return dirname(fileURLToPath(import.meta.resolve(`${value}/package.json`)));
           }`,

---

474-481: Resolve internal package root robustly

Minor: this path is resolved at runtime; if resolution ever fails in monorepos, adding a base to import.meta.resolve avoids edge cases.

-      commonAssetsDir: join(
-        dirname(fileURLToPath(import.meta.resolve('create-storybook/package.json'))),
+      commonAssetsDir: join(
+        dirname(fileURLToPath(import.meta.resolve('create-storybook/package.json', import.meta.url))),
         'rendererAssets',
         'common'
       ),

MIGRATION.md (2)

570-574: Doc snippet uses require.resolve in ESM: add createRequire for correctness

Readers copying this into ESM will hit “require is not defined.” Show createRequire.

-import { dirname } from 'node:path';
-
-const getAbsolutePath = (input) =>
-  dirname(require.resolve(`${input}/package.json`));
+import { dirname } from 'node:path';
+import { createRequire } from 'node:module';
+const require = createRequire(import.meta.url);
+const getAbsolutePath = (input) =>
+  dirname(require.resolve(`${input}/package.json`));

---

579-581: Builder example: clarify URL vs path

import.meta.resolve('@storybook/builder-vite') returns a URL string. Consider adding a short note or fileURLToPath in the example to prevent confusion for consumers expecting a filesystem path.

Suggested edit:

-  builder: import.meta.resolve('@storybook/builder-vite'),
+  // Resolve to a file URL, convert to a path if needed:
+  // builder: fileURLToPath(import.meta.resolve('@storybook/builder-vite')),
+  builder: import.meta.resolve('@storybook/builder-vite'),

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

code/frameworks/angular/src/preset.ts (1)

36-40: Consider normalizing builder name resolution

import.meta.resolve returns a file URL. Prefer passing either the package specifier or a file path for consistency with the Windows fix. Verify which form the core expects here.

Two safe options (pick one, confirm e2e on Windows/Yarn PnP):

-      name: import.meta.resolve('@storybook/builder-webpack5'),
+      name: '@storybook/builder-webpack5',

or

-      name: import.meta.resolve('@storybook/builder-webpack5'),
+      name: fileURLToPath(import.meta.resolve('@storybook/builder-webpack5')),

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

code/core/src/common/presets.ts (1)

239-242: Align error logging with stack/message for consistency

Mirror the improved logging used above so stack traces are printed reliably here as well.

Apply this diff:

-    logger.warn(warning);
-    logger.error(error);
+    logger.warn(warning);
+    const err = error as Error;
+    logger.error(err.stack ?? err.message);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro